Add difficulty to JSON-RPC blocks #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibilty with ethers 6, which fails with `Error: invalid value for value.difficulty`, otherwise.
|
|
2 tasks
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2082 +/- ##
=======================================
Coverage 54.30% 54.30%
=======================================
Files 692 692
Lines 115642 115643 +1
=======================================
+ Hits 62795 62800 +5
- Misses 49014 49017 +3
+ Partials 3833 3826 -7
☔ View full report in Codecov by Sentry. |
|
Coverage from tests in coverage: 49.7% of statements across all listed packagescoverage: 63.5% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.7% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 61.2% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
palango
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For compatibilty with ethers 6, which fails with
Error: invalid value for value.difficulty, otherwise.Tested
The regression test is included in #2081. This PR is provided separately, in case the other PR takes long to merge due to a potentially required node version update for recent ethers versions (node>=14).
Related issues
Backwards compatibility
Adding a field to the JSON object should be harmless for reasonably implemented users. I also don't know a way to fix the problem in an even safer way.