Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for Anvil migrations #10999

Closed
Tracked by #10990
arthurgousset opened this issue May 20, 2024 · 4 comments · Fixed by #11002
Closed
Tracked by #10990

Add integration tests for Anvil migrations #10999

arthurgousset opened this issue May 20, 2024 · 4 comments · Fixed by #11002
Assignees
@arthurgousset

Comments

@arthurgousset
Copy link
Member

arthurgousset commented May 20, 2024 •
edited

The current migration script that generates the Anvil devchain has no tests. Effectively, the devchain is generated and not tested.

DevTooling wants to start using the Anvil devchain for its test suite and CI, so we need to assert the devchain is setup correctly. For example:

The goal is to add automated tests that assert the devchain has been generated correctly.

The Anvil migration script deployed and configures a long list of contracts, each of which probably needs to be tested somehow. On the other hand, we have existing Foundry tests.
@arthurgousset arthurgousset mentioned this issue May 20, 2024
Open
@arthurgousset arthurgousset self-assigned this May 20, 2024
@arthurgousset arthurgousset mentioned this issue May 21, 2024
Merged
@arthurgousset
Copy link
Member Author

arthurgousset commented May 21, 2024 •
edited

Started working on this today

Edit: I didn't work on this yet, instead we agreed to prioritise this last week:

@arthurgousset arthurgousset changed the title Add automated integration tests for Anvil migrations Add end-to-end tests for Anvil migrations May 28, 2024
@arthurgousset
Copy link
Member Author

I'm starting work on this today.

@arthurgousset arthurgousset changed the title Add end-to-end tests for Anvil migrations Add integration tests for Anvil migrations May 31, 2024
@lvpeschke
Copy link
Contributor

Weekly commitment check-in: @arthurgousset can you provide a status update?

@arthurgousset
Copy link
Member Author

arthurgousset commented Jun 3, 2024 •
edited

This issue is closed by this PR:

The PR is functionally complete and ready for review.
The reason it's blocked is an unrelated failing test on CI that I'm debugging.
Including PR review, I expect this issue to be closed tomorrow Tue, Jun 4.

The progress on this issue is in line with the estimated timeline. The estimated completion was set at Tue, Jun 4.

I'll start working on my new weekly commitment tomorrow as estimated in that issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurgousset arthurgousset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add integration tests for Anvil migrations celo-org/celo-monorepo
2 participants
@lvpeschke @arthurgousset