-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate account:register to anvil #243
Conversation
🦋 Changeset detectedLatest commit: a2b474b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 71.70% 67.34% -4.37%
==========================================
Files 199 125 -74
Lines 8275 5905 -2370
Branches 1253 957 -296
==========================================
- Hits 5934 3977 -1957
+ Misses 2264 1880 -384
+ Partials 77 48 -29 ☔ View full report in Codecov by Sentry. |
58860ca
to
8a6faa8
Compare
🔥☄️ |
@@ -0,0 +1,5 @@ | |||
--- | |||
'@celo/dev-utils': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Should this be a minor? Seems like a new feature, rather than a bug fix.
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes
Source: https://semver.org/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -61,7 +61,7 @@ Use `yarn docs` to populate `packages/docs` with generated documentation. Genera | |||
|
|||
### Testing | |||
|
|||
We use both ganache and anvil for testing. You'll need foundry installed on your machine. | |||
We use both ganache and anvil for testing. You'll need [foundry](https://book.getfoundry.sh/getting-started/installation) installed on your machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This PR introduces a way to test against an anvil instance instead of currently used ganache. As a proof of concept "account:register" CLI command is migrated to use it.
Other changes
Mostly test util changes.
Tested
Ran tests locally.
Related issues
Backwards compatibility
Backwards compatible.
Documentation
None.
PR-Codex overview
This PR introduces testing with a local Anvil instance using
testWithAnvil
. It also adds Anvil setup in tests and updates dependencies.Detailed summary
testWithAnvil
for local Anvil testing@viem/anvil
TODO