Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped Notifications should include outstanding payment requests #1744

Closed
nityas opened this issue Nov 15, 2019 · 3 comments · Fixed by #1902
Closed

Grouped Notifications should include outstanding payment requests #1744

nityas opened this issue Nov 15, 2019 · 3 comments · Fixed by #1902
Assignees
Labels
enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority wallet
Projects

Comments

@nityas
Copy link
Contributor

nityas commented Nov 15, 2019

Expected Behavior

When a payment request is sent, a notification should be added to the notification center giving the user the option to either 'remind' or 'cancel' the payment request
figma link
Once the payment request is completed, this notification should be removed from the notification center.

Current Behavior

payment requests are not displayed.

@nityas nityas added wallet applications enhancement an improvement to an existing feature Priority: P2 Major labels Nov 15, 2019
@nityas nityas added this to To do in 2019-11-20 via automation Nov 15, 2019
@nityas nityas added the triaged label for issues that have been assigned a priority label Nov 19, 2019
@i1skn i1skn self-assigned this Nov 20, 2019
@i1skn i1skn moved this from To do to In progress in 2019-11-20 Nov 21, 2019
@i1skn
Copy link
Contributor

i1skn commented Nov 27, 2019

@nityas I've notice that these two text have different prepositions in Figma file. Should not we use the same instead? Just curious :)
Screenshot 2019-11-27 at 16 33 20

@i1skn i1skn moved this from In progress to Review in progress in 2019-11-20 Nov 27, 2019
@nityas
Copy link
Contributor Author

nityas commented Nov 27, 2019 via email

@coreycelo
Copy link

👍 for consistent language—"for you" is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement an improvement to an existing feature Priority: P2 Major triaged label for issues that have been assigned a priority wallet
Projects
No open projects
2019-11-20
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants