Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate BlochainParameters Contract on L2 #11008

Merged
merged 5 commits into from
May 28, 2024

Conversation

soloseng
Copy link
Contributor

@soloseng soloseng commented May 23, 2024

Description

Functions that call precompiles now revert on L2.

Other changes

Removed an edge-case test that was only relevant when running test on Ganache, where the epoch size was set to 100

Tested

Unit testes

Related issues

@soloseng soloseng self-assigned this May 23, 2024
@soloseng soloseng marked this pull request as ready for review May 23, 2024 20:39
@soloseng soloseng requested a review from a team as a code owner May 23, 2024 20:39
Copy link
Member

@arthurgousset arthurgousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment on EPOCH_SIZE. Not sure if any changes are needed, but thought I'd flag in case.

@soloseng soloseng enabled auto-merge (squash) May 28, 2024 16:48
@soloseng soloseng merged commit 1644216 into master May 28, 2024
24 checks passed
@soloseng soloseng deleted the soloseng/deactivate-blockchain-parameters branch May 28, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants