Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade foundry version to match across workflows #11017

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

arthurgousset
Copy link
Member

@arthurgousset arthurgousset commented Jun 5, 2024

Description

Small follow-on PR to downgrade the foundry version in protocol-devchain-anvil.yml to match the version in protocol_tests.yml.

#11002 downgraded the foundry version, but CI didn't catch the failing protocol-devchain-anvil.yml workflow on that branch, because the workflow only runs on master.

Other changes

None

Tested

No, we'll know this works when we merge this PR to master and run the workflow.

Related issues

None

Backwards compatibility

Yes

Documentation

No

This should match the version set in `protocol_tests.yml`.
This PR downgraded the foundry version, but CI didn't catch the failing workflow on the feature branch, because `protocol-devchain-anvil.yml` only runs on `master`.
@arthurgousset arthurgousset requested a review from a team as a code owner June 5, 2024 11:59
@arthurgousset arthurgousset requested review from jcortejoso and a team June 5, 2024 11:59
@arthurgousset arthurgousset changed the title fix: downgrades foundry version in "generate anvil" workflow to match "protocol tests" workflow chore: downgrades foundry version in "generate anvil" workflow to match "protocol tests" workflow Jun 5, 2024
@arthurgousset arthurgousset changed the title chore: downgrades foundry version in "generate anvil" workflow to match "protocol tests" workflow chore: downgrades foundry version to match across workflows Jun 5, 2024
@arthurgousset arthurgousset changed the title chore: downgrades foundry version to match across workflows chore: downgrade foundry version to match across workflows Jun 5, 2024
@arthurgousset arthurgousset merged commit 0f28027 into master Jun 5, 2024
21 checks passed
@arthurgousset arthurgousset deleted the arthurgousset/fix/generate-anvil-CI-workflow branch June 5, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants