[L02] Inconsistent quorum calculation #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2796 +/- ##
==========================================
- Coverage 73.58% 73.58% -0.01%
==========================================
Files 567 567
Lines 14160 14162 +2
Branches 1464 1703 +239
==========================================
+ Hits 10420 10421 +1
- Misses 3455 3458 +3
+ Partials 285 283 -2
Continue to review full report at Codecov.
|
…-monorepo into mrsmkl/min-quorum-size-l02
…l/min-quorum-size-l02
asaj
reviewed
Feb 18, 2020
| @@ -83,7 +83,8 @@ const INTRINSIC_TX_GAS_COST = 21000 | |||
| // Additional intrinsic gas for a transaction with fee currency specified | |||
| const ADDITIONAL_INTRINSIC_TX_GAS_COST = 50000 | |||
|
|
|||
| const stableTokenTransferGasCost = 20653 | |||
| // const stableTokenTransferGasCost = 20653 | |||
There was a problem hiding this comment.
This sometimes changes, haven't found the reason yet...
There was a problem hiding this comment.
+1 to this. We need to make sure we know why gas costs change.
There was a problem hiding this comment.
It was because a public method was added to UsingPrecompiles, so the routing code changed.
…-monorepo into mrsmkl/min-quorum-size-l02
nategraf
reviewed
Feb 19, 2020
| @@ -83,7 +83,8 @@ const INTRINSIC_TX_GAS_COST = 21000 | |||
| // Additional intrinsic gas for a transaction with fee currency specified | |||
| const ADDITIONAL_INTRINSIC_TX_GAS_COST = 50000 | |||
|
|
|||
| const stableTokenTransferGasCost = 20653 | |||
| // const stableTokenTransferGasCost = 20653 | |||
There was a problem hiding this comment.
+1 to this. We need to make sure we know why gas costs change.
…l/min-quorum-size-l02
asaj
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested
Other changes
Related issues
Backwards compatibility