Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N04] MockReserve.sol has mintToken function #3281

Merged
merged 1 commit into from Apr 3, 2020
Merged

[N04] MockReserve.sol has mintToken function #3281

merged 1 commit into from Apr 3, 2020

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Apr 2, 2020

Description

The MockReserve contract has a mintToken function, while the contract it is based on, Reserve, does not.

Related issues

@asaj asaj requested a review from m-chrzan as a code owner April 2, 2020 13:28
@asaj asaj added the audit-fix label Apr 2, 2020
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #3281 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3281   +/-   ##
=======================================
  Coverage   75.91%   75.91%           
=======================================
  Files         614      614           
  Lines       15366    15366           
  Branches     1909     1835   -74     
=======================================
  Hits        11665    11665           
- Misses       3370     3372    +2     
+ Partials      331      329    -2     
Flag Coverage Δ
#mobile 75.75% <ø> (ø)
#web 76.11% <ø> (ø)
Impacted Files Coverage Δ
packages/web/src/utils/utils.ts 79.62% <0.00%> (ø)
packages/web/src/utils/abortableFetch.ts 71.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e703e32...9fb7a0b. Read the comment docs.

Copy link
Contributor

@mrsmkl mrsmkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asaj asaj assigned asaj and unassigned mrsmkl Apr 2, 2020
@asaj asaj merged commit de62388 into master Apr 3, 2020
@asaj asaj deleted the asaj/n04 branch April 3, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants