Enable PNP DEK Auth #4626
Merged
Enable PNP DEK Auth #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annakaz
approved these changes
Aug 4, 2020
jmrossy
approved these changes
Aug 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #4626 +/- ##
=========================================
Coverage ? 74.38%
=========================================
Files ? 323
Lines ? 10378
Branches ? 1053
=========================================
Hits ? 7720
Misses ? 2490
Partials ? 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ewilz
pushed a commit
to ewilz/celo-monorepo
that referenced
this pull request
Sep 29, 2020
* Add phone-number-privacy-common@1.0.5 to yarn.lock * Enable PNP DEK Auth * Remove yarn.lock update Co-authored-by: Cody Born <codyborn@codys-mbp.lan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that six of nine PNP Signers have updated, we can enable this auth method in the mobile app. This improves the user experience by not requesting the user to enter her pin on each request.
Tested
Tested using android emulator pointing to mainnet. Verified salt query with DEK and without.
Do not merge
I'll merge this once we have 7 of 9 signers updated.