Update fastlane to avoid vulnerability in mini_magick #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependency of fastlane, update fastlane. Since the version of fastlane with the fix isn't released to RubyGems yet, temporarily point to github as the source for this gem.
jmrossy
approved these changes
Jul 19, 2019
|
LG from this former rails dev |
aaronmgdr
pushed a commit
that referenced
this pull request
Sep 28, 2023
…/cookiejar-2.1.4 Bump cookiejar from 2.1.3 to 2.1.4 in /examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We got a security alert because of the version of
mini_magickused by the mobile package. This is a dependency offastlane 2.127.1, so can't be updated directly. The fix is included on the master branch offastlaneon github, but hasn't made it into a release on RubyGems yet.For reference, this is the commit where it's fixed: fastlane/fastlane#15042
To avoid waiting for that release to fix the vulnerability here, this PR points the source of
fastlaneat github. This can be switched back oncefastlane's next release makes it to RubyGems. This followup task is covered in #53.Tested
Tested by locally deploying the app to the store.