Remove gas price sections from docs for using Metamask. #8103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When CIP35 was being developed, Metamask did not properly handle setting a gas price for networks other than Ethereum's mainnet. Since then, however, they have fixed this by querying the node's eth_gasPrice method. Since this is how we were recommended developers choose a gas price, it is not redundant as Metamask does it by itself.
oneeman
added
automerge
oneeman
requested review from
barbaraliau,
critesjosh and
timmoreton
as code owners
tkporter
pushed a commit
that referenced
this pull request
Jul 8, 2021
When CIP35 was being developed, Metamask did not properly handle setting a gas price for networks other than Ethereum's mainnet. Since then, however, they have fixed this by querying the node's eth_gasPrice method. Since this is how we were recommended developers choose a gas price, it is not redundant as Metamask does it by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When CIP35 was being developed, Metamask did not properly handle setting a gas price for networks other than Ethereum's mainnet (see MetaMask/metamask-extension#10444). Since then, however, they have fixed this by querying the node's eth_gasPrice method. Since this is how we were recommended developers choose a gas price, it is now redundant as Metamask does it by itself.
This PR updates the docs for using Metamask with Celo, removing the sections about having to set the gas price yourself.
Other Changes
Some trailing whitespace removed automatically by VS Code
Tested
Verified that metamask sets the gas price correctly on its own when connected to mainnet, baklava, and a local network running on my computer.