Add coinbase wallet support #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cb-jake is attempting to deploy a commit to the cLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
On First pass looks good. (except for the failing tests) |
cb-jake
force-pushed
the
coinbase
branch
2 times, most recently
from
42f2d4f
to
80accf8
Compare
|
@aaronmgdr This should be ready for review. Tests are passing and I've added some tests for the connector. Let me know if you have any feedback! Thanks! |
aaronmgdr
reviewed
Jun 17, 2022
|
Just played around with connecting via cb wallet on my phone. one thing that came up which i wished I screenshoted was that it added the tokens the UI on the wallet app showed the symbol for all as "WONE" im not sure why. when i look at the crypto screen on wallet they show up correct. also the Alfajores Testnet is not placed in the wallet's testnets section for chains. (this got my thinking that react-celo doenst indicate its a testnet either) |
|
Thanks @aaronmgdr taking a look now to see why the custom tokens are coming in as "WONE". Are you testing on iOS or Android? Interesting that it ended up in the mainnets section. I'm not super familiar with this on the wallets app side but I'll look into that. |
|
@cb-jake Im on iOS |
aaronmgdr
approved these changes
Jun 23, 2022
nicolasbrugneaux
approved these changes
Jun 27, 2022
aaronmgdr
added a commit
that referenced
this pull request
Aug 22, 2022
* chore: Label all issues in repo as Applications so they show in zenhub * FEAT: Allow developers to pass in any networks they wish add passed networks as a return value of useContractKit replace NetWorkNames Enum with POJO so that its extendable Make Network interface support arbitrary networks and include option to pass in the nativeCurrency which is used when adding to metamask. For non celo networks dont try to add celo tokens to metamask * fix: update Fee Currency should only be an option for Connectors / wallets that support alternative gas fee currencies * lint extra imports * expose supportsFeeCurrency so devs can use to display conditional fee currency setting ops + demo it in our example app * make it clear why we are returning false * conflict * Append current browser location in Metamask mobile * replacing use of contractkit with minicontractkit * Missing Import * Add optional contractCache builder and memoization * Catch token not registered error, display balances * Fix empty block * Change value to be type string * Log error * upgrade to react 18 add testing utils start testing of Provider and hook * upgrade jest and friends remove react-test-render as we dont use and its not cool * feat: redesign and wc fixes (#169) * added search bar * added search bar and optimization * made some changes * feat: initial redesign * chore: remove unused unstated-next * chore: review feedback * fix: bad merge + pr review * perf: search * feat: adjust install logic Co-authored-by: Henry Nunez <henry.nunez@clabs.co> * Balances has BigNumber value and string error * chore: Add svg icon for celo terminal (#69) Add svg icon for celo terminal * docs: improve readme (#184) * docs(readme): fix typo * docs(readme): add better development instructions * refactor: remove check for window * docs(readme): remove v2 of WC from example * docs(readme): add wallets to list * docs(readme): add supported actions * fix: issue labeler error * fix(docs): original instructions with alternative * fix: remove toggle z-index to not interfere * fix: remove specific actions from wallet (#188) * move to target es6 All major browsers support es6 and this should improve bundle size too. https://www.typescriptlang.org/tsconfig#target * Renames use-contract kit to react-celo 4.0 now requires contractkit 2.0 and greater * fix typo Co-authored-by: Camila Rondinini <crondinini@gmail.com> * Add test for modal * no message * Add basic level testing for private-key and wallet connect connectors. * If the network is not set here than initialise call will just re establish connection to metamask with this.network (probably the one it was constructed with) * fix: adjust styles for mobile and specifically for ios safari (#192) * codeReview from @dckesler * Feat/theming (#198) * feat: initial theming * chore: codereview * test: add updateTheme tests * Add Aliases for old function names (#204) Add Aliases for old function names so its not a pain to upgrade to v4 * feat: wallet test plan page (#205) adds a page to the Example app (hidden in this commit) where the user can go through a set of steps to check how well a wallet interacts with the available actions of the package. * fix: export useContractKit (#215) * Some Network Change Errors (#216) * Add tests for address handling in reducer fix test file being misnamed fix some error messages and code comments to be more clear * fix #214 There was a destructuring error when init was not passed which is legal as its optional * fixes #209 when switching network feeCurrency could be undefined. In that case lets skip setting it. * fix: celo-wallet web connection (#217) * fix: celo-wallet web connection * refactor: rename getDesktopLink->getWebLink * fix: destroy not re-rendering * refactor: deeplinks and weblinks logic * Allow updateTheme to take a null value (#219) * Fix #211 Cleanup Init Errors (#223) * Fix #211 Cleanup Init Errors when going to a new Wallet Screen or closing the modal * lint: remove unused import * fix: handle disconnect events coming from sessionUpdate events * fix: show qrcode for mobile connectors * chore: eslint warnings * feat: show mobile disclaimer on apps with a deeplink * fix dark toggle on example app (#227) * Move the toggle down by the rest of the styling options this way it isnt blocking everything on mobile. also make it a little smaller * update the used by list not to include projects that are dead or use a fork * Change css classes to react-celo, include necessary TW css (#231) * 4.0 Alpha 2 * fix example app dependencies (#233) * fix example app dependencies * attempt fix on deploy * chore: configure test in example app (#234) Sets up tests in the example app, using the configuration from the root (modified only to accept .test files outside of __tests__). * docs: Add Migration Guide for v4 (#235) * Add Guides Co-authored-by: Camila Rondinini <crondinini@gmail.com> * style consistency Co-authored-by: Camila Rondinini <crondinini@gmail.com> * pr review @crondinini: clarify version needed * add proper link to release notes Co-authored-by: Camila Rondinini <crondinini@gmail.com> * v4.0.0-beta.1 (React Celo Beta 1) * refactor(useCelo types): make it explicit where types are coming from (#236) The same types were repeated in 3 different places. This reuses existing types instead of repeating them. As a side effect, it also moves documentation to where it's implemented and adds some missing ones. * fix add proper Type for initialState (#238) * remove ethereumjs utils (#242) * wip Removes ethereumjs-utils by copying the few functions we use from it and using alternatives * rename files, add license, add tests * remove name from jest config as it causes a warning * Optimize SVGs (#239) run svgs thru an optimizer then convert back to jsx to save bytes. (saved about 30%) (19k vs 30k) on wallet Icons * fix: Celo Utils is not used in react-celo, only in the example app (#240) Celo Utils is not used in react-celo, only in the example app * feat: add packages publisher (#241) * 4.0 release * feat: a11y/colors (#221) * feat: first pass at color checking * test: add color tests * Typed Local Storage (#243) * Access Local Storage Thru specific getter and setter functions only * remove extra file * remove some unneeded code * review: swtich to 2 typed functions rather than getter/setter per key add tests * lint and test * refactor: extract connectors, icons and standardize filenames (#260) * refactor: extract connectors and remove capitalization * refactor: extract wallet icons * chore: eslint * refactor: move use-contracts-cache * refactor: component naming * refactor: remove unused variable * fix 2 spots where old repo name was used (#262) * Update issue templates (#228) Co-authored-by: Camila Rondinini <crondinini@gmail.com> * Fix npm Badge (#263) * feat: wallet test plan (more tests and add to home) (#264) * fixes #203 deprecated network prop (#269) * fixes #203 deprecated network prop add defaultNetworkProp allow both for now. and favor network so that this is a nonbreaking change unless you count that this fixes passing in a unfindable network now throws an error instead of silently defaulting to mainnet * feat: create ressursurector, updator, & persistor * Persistor and Updator respond to events from Connectors * add persistor test and lint * Better emissions typing * improve typings and add explicit event emitter package ( very small) * add test for walletID (used by getRecent()) * When Modal is Open Dont Allow Background to scroll (#270) * Connect modal disable background scroll * Action modal disable background scroll * Fix linting * Move to helper * Remove unused imports * Fix import order * Use window scroll in useFixedBody * Use document.body.style Co-authored-by: zhaonancy <nancy.zhao@clabs.co> * Accessibility Fixes (#273) * Chrome Lighthouse accessibility fixes * Fix URL Co-authored-by: zhaonancy <nancy.zhao@clabs.co> * Add coinbase wallet support (#266) * Add coinbase wallet support * Add dapp name and icon to coinbase wallet sdk * feat: logger (#244) * feat: logger * test: add logging tests * test: fix test * Stable merge (#285) * 4.0 release (#256) * chore: Label all issues in repo as Applications so they show in zenhub * FEAT: Allow developers to pass in any networks they wish add passed networks as a return value of useContractKit replace NetWorkNames Enum with POJO so that its extendable Make Network interface support arbitrary networks and include option to pass in the nativeCurrency which is used when adding to metamask. For non celo networks dont try to add celo tokens to metamask * fix: update Fee Currency should only be an option for Connectors / wallets that support alternative gas fee currencies * lint extra imports * expose supportsFeeCurrency so devs can use to display conditional fee currency setting ops + demo it in our example app * make it clear why we are returning false * conflict * Append current browser location in Metamask mobile * replacing use of contractkit with minicontractkit * Missing Import * Add optional contractCache builder and memoization * Catch token not registered error, display balances * Fix empty block * Change value to be type string * Log error * upgrade to react 18 add testing utils start testing of Provider and hook * upgrade jest and friends remove react-test-render as we dont use and its not cool * feat: redesign and wc fixes (#169) * added search bar * added search bar and optimization * made some changes * feat: initial redesign * chore: remove unused unstated-next * chore: review feedback * fix: bad merge + pr review * perf: search * feat: adjust install logic Co-authored-by: Henry Nunez <henry.nunez@clabs.co> * Balances has BigNumber value and string error * chore: Add svg icon for celo terminal (#69) Add svg icon for celo terminal * docs: improve readme (#184) * docs(readme): fix typo * docs(readme): add better development instructions * refactor: remove check for window * docs(readme): remove v2 of WC from example * docs(readme): add wallets to list * docs(readme): add supported actions * fix: issue labeler error * fix(docs): original instructions with alternative * fix: remove toggle z-index to not interfere * fix: remove specific actions from wallet (#188) * move to target es6 All major browsers support es6 and this should improve bundle size too. https://www.typescriptlang.org/tsconfig#target * Renames use-contract kit to react-celo 4.0 now requires contractkit 2.0 and greater * fix typo Co-authored-by: Camila Rondinini <crondinini@gmail.com> * Add test for modal * no message * Add basic level testing for private-key and wallet connect connectors. * If the network is not set here than initialise call will just re establish connection to metamask with this.network (probably the one it was constructed with) * fix: adjust styles for mobile and specifically for ios safari (#192) * codeReview from @dckesler * Feat/theming (#198) * feat: initial theming * chore: codereview * test: add updateTheme tests * Add Aliases for old function names (#204) Add Aliases for old function names so its not a pain to upgrade to v4 * feat: wallet test plan page (#205) adds a page to the Example app (hidden in this commit) where the user can go through a set of steps to check how well a wallet interacts with the available actions of the package. * fix: export useContractKit (#215) * Some Network Change Errors (#216) * Add tests for address handling in reducer fix test file being misnamed fix some error messages and code comments to be more clear * fix #214 There was a destructuring error when init was not passed which is legal as its optional * fixes #209 when switching network feeCurrency could be undefined. In that case lets skip setting it. * fix: celo-wallet web connection (#217) * fix: celo-wallet web connection * refactor: rename getDesktopLink->getWebLink * fix: destroy not re-rendering * refactor: deeplinks and weblinks logic * Allow updateTheme to take a null value (#219) * Fix #211 Cleanup Init Errors (#223) * Fix #211 Cleanup Init Errors when going to a new Wallet Screen or closing the modal * lint: remove unused import * fix: handle disconnect events coming from sessionUpdate events * fix: show qrcode for mobile connectors * chore: eslint warnings * feat: show mobile disclaimer on apps with a deeplink * fix dark toggle on example app (#227) * Move the toggle down by the rest of the styling options this way it isnt blocking everything on mobile. also make it a little smaller * update the used by list not to include projects that are dead or use a fork * Change css classes to react-celo, include necessary TW css (#231) * 4.0 Alpha 2 * fix example app dependencies (#233) * fix example app dependencies * attempt fix on deploy * chore: configure test in example app (#234) Sets up tests in the example app, using the configuration from the root (modified only to accept .test files outside of __tests__). * docs: Add Migration Guide for v4 (#235) * Add Guides Co-authored-by: Camila Rondinini <crondinini@gmail.com> * style consistency Co-authored-by: Camila Rondinini <crondinini@gmail.com> * pr review @crondinini: clarify version needed * add proper link to release notes Co-authored-by: Camila Rondinini <crondinini@gmail.com> * v4.0.0-beta.1 (React Celo Beta 1) * 4.0 release Co-authored-by: zhaonancy <nancy.zhao@clabs.co> Co-authored-by: Nancy Zhao <32007540+zhaonancy@users.noreply.github.com> Co-authored-by: Nicolas Brugneaux <nicolas.brugneaux@gmail.com> Co-authored-by: Henry Nunez <henry.nunez@clabs.co> Co-authored-by: J M Rossy <jm.rossy@gmail.com> Co-authored-by: Camila Rondinini <crondinini@gmail.com> Co-authored-by: Daniel Kesler <danielckesler@gmail.com> * Fixes #268 (-webkit-fill-available vs background gradient bug) use react modals custom classname to add the styles to html and body only when our modal is open * Fix (hideFromDefaults option not hiding wallets) (#275) * fixes #274 (hide from defaults not hiding wallets) * return an array of which default providers are being used. rather than reuse all screens, which would have had extra and potentially gotten weird * beta 1 * update example app * measure once cut twice * Fix handling of reactModalProp (#278) * fixes the connect modal not recognizing when it receives style props externally. * ensure out styles are not overwritten. * Remove Extra Global Styles (#282) * remove tailwind base as it is messing with global styles * remove unnessessary css resets for react-celo * fix vertical allignments * beta 2 * release * Release/4.0.1 (#277) * Fixes #268 (-webkit-fill-available vs background gradient bug) use react modals custom classname to add the styles to html and body only when our modal is open * Fix (hideFromDefaults option not hiding wallets) (#275) * fixes #274 (hide from defaults not hiding wallets) * return an array of which default providers are being used. rather than reuse all screens, which would have had extra and potentially gotten weird * Fix handling of reactModalProp (#278) * fixes the connect modal not recognizing when it receives style props externally. * Remove Extra Global Styles (#282) * remove tailwind base as it is messing with global styles * remove unnessessary css resets for react-celo * fix vertical allignments * merge release/4.0.1 into master * fix merge issues * remove duplicated files Co-authored-by: zhaonancy <nancy.zhao@clabs.co> Co-authored-by: Nancy Zhao <32007540+zhaonancy@users.noreply.github.com> Co-authored-by: Nicolas Brugneaux <nicolas.brugneaux@gmail.com> Co-authored-by: Henry Nunez <henry.nunez@clabs.co> Co-authored-by: J M Rossy <jm.rossy@gmail.com> Co-authored-by: Camila Rondinini <crondinini@gmail.com> Co-authored-by: Daniel Kesler <danielckesler@gmail.com> * fix: regression in priority and style issue (#284) * fix: regression in priority and style issue * refactor: remove all variable shadowings * chore(deps): bump parse-url from 6.0.0 to 6.0.2 (#286) Bumps [parse-url](https://github.com/IonicaBizau/parse-url) from 6.0.0 to 6.0.2. - [Release notes](https://github.com/IonicaBizau/parse-url/releases) - [Commits](https://github.com/IonicaBizau/parse-url/commits) --- updated-dependencies: - dependency-name: parse-url dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * New Look for Demo Site (#290) fixes #258 * Make Top nav fixed to top and full width * add footer * add NPM link to nav * redesign home and layout, add nice colors, add footer more showcase like * add dark mode to the home page * make sure dark mode is ok on other pages * Internal rewrite (#288) * All Connectors emit Disconnect Event * Connectors emit connected events with params * make emit protected, ONLY callable by connectors, also fix cew test * switch address change to be emited event * WIP * replace loadConfig with resurector + loadPreviusState Move celo provider helpers to their own files. add listeners * remove persists * fix connector stub * end reducer effecting local storage * fix tests, no local storage * connector listerns must be listening BEFORE initialise is called * remove clearPreviousConfig calls from connectors * split up client settup from fetching URI. allow getURI to be called multiple times without creating new clients * expend test for wallet connect * missed extra import * WIP better netowkr changers * a little cleanup * remove unused code * fix tests * tests pass * wip Wallet connect connector connecting steps, changing networks, disconnecting, and inbetween steps * improve wc, handle CBW disconnect, remove account * update todos * fix lint errors * fix ts build * cleanup * replace console.xxx with our custom logger * self review * clear up verbose test runs * lint up * clean up tests. remove weird exit code * revert * add second test condition * more self review * review (@nicolasbrugneaux) rename destroy to disconnect for linguistic symmetry with connect action * a more reasonable time * unmount in the tests * mocking the balance might be why there is a balance Co-authored-by: Aaron DeRuvo <aaron.deruvo@clabs.co> * 4.1.0 alpha 1 * fix versions * Fix style bugs (#293) * add a default zindex of 40 (can be over written) (no need for mobile check here is both are the same) * fix body height while modal is open (in cases where the content isnt enought to push to full screen) * ensure full list of wallets is not bigger than viewable area / push up final by adding padding * Alpha 2 * Fix improper error when metamask gets locked (#298) * when metamask extension is locked it shows their being zero accounts available. Before it would error out and disconnect, Now we explicitly close (this is the same behavior rainbow wallet and uniswap.org did) * add properties that were missing on type * 4.1 Beta 1 * Fix z-index class not being properly prefixed * Beta 2 * Fix regression metamask network regression (#300) Fix regression where metamask would not be automatically switched to the dapp network. also fix token import to metamask to use new mento uri for logo * 4.1 Beta 3 Co-authored-by: zhaonancy <nancy.zhao@clabs.co> Co-authored-by: Nancy Zhao <32007540+zhaonancy@users.noreply.github.com> Co-authored-by: Nicolas Brugneaux <nicolas.brugneaux@gmail.com> Co-authored-by: Henry Nunez <henry.nunez@clabs.co> Co-authored-by: J M Rossy <jm.rossy@gmail.com> Co-authored-by: Camila Rondinini <crondinini@gmail.com> Co-authored-by: Daniel Kesler <danielckesler@gmail.com> Co-authored-by: cb-jake <95890768+cb-jake@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron DeRuvo <aaron.deruvo@clabs.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Coinbase wallet extension and mobile.