Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing Phase 2 #44

Merged
merged 5 commits into from Apr 1, 2020
Merged

Tracing Phase 2 #44

merged 5 commits into from Apr 1, 2020

Conversation

gakonst
Copy link

@gakonst gakonst commented Apr 1, 2020 •
edited

Fixes #36

As title. I've modified one of the tests to also run a logger so that we can see the result by running RUST_LOG=trace cargo test -- --nocapture

Result:

Contribute
image

Verify
image

@gakonst gakonst requested a review from kobigurk April 1, 2020 19:09
kobigurk
kobigurk approved these changes Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@kobigurk kobigurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed some inconsistency between capitlization in log messages, would be good to keep one style - i.e., all lowercase.

@gakonst gakonst merged commit e482b0d into master Apr 1, 2020
@gakonst gakonst deleted the tracing-2 branch April 1, 2020 20:34
@gakonst gakonst mentioned this pull request May 22, 2020
Closed
@gakonst gakonst mentioned this pull request Jun 21, 2020
Closed
@gakonst gakonst mentioned this pull request Nov 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobigurk kobigurk kobigurk approved these changes

Assignees

@kobigurk kobigurk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use tracing
2 participants
@gakonst @kobigurk