This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Preparation for ReadInputs3 being optional #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might use this if we request ReadInputs1 & 2 every 10 seconds, but not 3; this mirrors what the app does. Therefore we'll need to store just the data we have. Start off by making database columns NULLable.
We might use this if we request ReadInputs1 & 2 every 10 seconds, but not 3; this mirrors what the app does. Therefore we'll need to store just the data we have. Start off by making database columns NULLable.
celsworth
force-pushed
the
make-read-inputs-3-optional
branch
from
c569c97
to
36da1b9
Compare
celsworth
force-pushed
the
master
branch
2 times, most recently
from
d41335a
to
6043637
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might use this if we request ReadInputs1 & 2 every 10 seconds, but not 3; this mirrors what the app does.
Therefore we'll need to store just the data we have.
Start off by making database columns NULLable, and allowing ReadInputsAll not to have RI3 data.
Part of #113.