Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove locksmith dependency #37

Merged
merged 9 commits into from Aug 15, 2019
Merged

Conversation

initFabian
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2019

Codecov Report

Merging #37 into master will decrease coverage by 5.2%.
The diff coverage is 83.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   94.86%   89.65%   -5.21%     
==========================================
  Files          27       20       -7     
  Lines        1519      899     -620     
==========================================
- Hits         1441      806     -635     
- Misses         78       93      +15
Impacted Files Coverage Δ
Cely Demo/AppDelegate.swift 66.66% <ø> (ø) ⬆️
Cely Demo/LoginStyles.swift 86.66% <0%> (ø) ⬆️
Tests/CelyStorageTests.swift 91.3% <100%> (ø) ⬆️
Tests/LoginViewControllerTests.swift 100% <100%> (ø) ⬆️
Sources/CelyStorage.swift 100% <100%> (+1.16%) ⬆️
Sources/LocksmithError.swift 66.66% <75%> (-29.17%) ⬇️
Sources/CelyKeychain.swift 76.08% <76.08%> (ø) ⬆️
Sources/CelySecureStorage.swift 92% <92%> (ø) ⬆️
Sources/CelyConstants.swift 63.88% <0%> (-36.12%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4d341...3051b3b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 27, 2019

Codecov Report

Merging #37 into master will decrease coverage by 5.43%.
The diff coverage is 86.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   95.17%   89.73%   -5.44%     
==========================================
  Files          25       19       -6     
  Lines        1429      906     -523     
==========================================
- Hits         1360      813     -547     
- Misses         69       93      +24
Impacted Files Coverage Δ
Sources/CelyStorage.swift 100% <100%> (+8.69%) ⬆️
Tests/CelyStorageTests.swift 91.3% <100%> (ø) ⬆️
Sources/LocksmithError.swift 58.33% <50%> (-41.67%) ⬇️
Sources/CelySecureStorage.swift 85.89% <85.89%> (ø)
Sources/CelyConstants.swift 63.88% <0%> (-36.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a556b75...8791a02. Read the comment docs.

@initFabian
Copy link
Collaborator Author

fixes #32

Copy link
Collaborator

@alextall alextall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple minor comments.

// Cely-iOS
//
// Created by Fabian Buentello on 8/7/19.
// Copyright © 2019 ChaiOne. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can update your © for the project. 😛

}

func get(_ key: String) -> Any? {
if let value = store[key] {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is functionally equivalent to return store[key]

@initFabian initFabian merged commit 2c7aad2 into master Aug 15, 2019
@initFabian initFabian deleted the remove-locksmith-dependency branch August 15, 2019 13:55
@initFabian initFabian mentioned this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants