Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update typing offset_to_depth and depth_to_offset #339

Merged
merged 1 commit into from
Jul 21, 2023
Merged

chore: update typing offset_to_depth and depth_to_offset #339

merged 1 commit into from
Jul 21, 2023

Conversation

RDWimmers
Copy link
Member

make mypy happy with typing. Add NDArray type support

@RDWimmers RDWimmers added enhancement New feature or request python Pull requests that update Python code labels Jul 3, 2023
@RDWimmers RDWimmers requested a review from tlukkezen July 3, 2023 15:01
@RDWimmers RDWimmers self-assigned this Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5445954104

  • 11 of 15 (73.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 87.321%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pygef/common.py 11 15 73.33%
Totals Coverage Status
Change from base Build 5212846414: -0.2%
Covered Lines: 978
Relevant Lines: 1120
💛 - Coveralls

@tversteeg tversteeg merged commit 586c60c into master Jul 21, 2023
15 checks passed
@tversteeg tversteeg deleted the update_typing_common_function branch July 21, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlukkezen tlukkezen tlukkezen approved these changes

Assignees

@RDWimmers RDWimmers

Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RDWimmers @tlukkezen @tversteeg