Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thread names #1120

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Update thread names #1120

merged 1 commit into from
Mar 15, 2024

Conversation

goeiecool9999
Copy link
Contributor

Fixes #1013
I set out to change the main thread name to cemu like I suggested in #1116 and in the process I discovered that many threads did not get their proper names on Linux. The man page for pthread_setname_np states: The thread name is a meaningful C language string, whose length is restricted to 16 characters, including the terminating null byte ('\0'). This means that there are only 15 usable characters. Instead of cutting them off at 15 characters I decided to find shorter names. I opted to change the names for all platforms because having preprocessor macros would make things needlessly cluttered. I also discovered some nameless threads and named them.
The killall cemu command now works as expected.

Before patch After patch
image

on linux names have to be less than 16 characters, so I tried finding a reasonable compromise between descriptiveness and brevity.
@Exzap Exzap merged commit eaa8281 into cemu-project:main Mar 15, 2024
5 checks passed
@goeiecool9999 goeiecool9999 deleted the threadnames branch March 15, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application has no proper title and ignores SIGTERM
2 participants