Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to game shortcuts and UTF8 gamelist name fixes #1126

Merged
merged 14 commits into from
Mar 24, 2024

Conversation

capitalistspz
Copy link
Contributor

@capitalistspz capitalistspz commented Mar 17, 2024

  • Windows icons are stored as .ico files to %LOCALAPPDATA%/Cemu/icons/
  • Long title names chosen as some games (NSMBU + NSLU) add trailing dots for their shortnames
  • Long title names have their newlines replaced with spaces at parsing
  • Linux shortcut paths are saved with UTF-8 encoding
  • Game titles are copied and saved with UTF-8 encoding

Comment on lines 1286 to 1288
wxString appimagePath;
if (wxGetEnv(("APPIMAGE"), &appimagePath))
exePath = appimagePath.utf8_string();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to introduce a reusable ActiveSettings::GetRealExecutablePath instead of hardcoding the appimage path handling here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that ActiveSettings::GetExecutablePath is only used for shortcuts and the autoupdater, maybe it simply should be the executable path?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that makes more sense

@capitalistspz capitalistspz marked this pull request as draft March 19, 2024 02:50
@capitalistspz capitalistspz marked this pull request as ready for review March 19, 2024 05:11
@lijunyu-cn
Copy link
Contributor

lijunyu-cn commented Mar 19, 2024

For multi-charset systems, there may be some issues with newly created shortcut names, and the same problem occurs when copying the Title Names. Could you fix it in this PR, I tried using wxString::FromUTF8(gameInfo.GetTitleName()) in Win10 to solve this problem, but this is just a small issue, not worth opening a separate PR.

@capitalistspz capitalistspz changed the title Add icons to Windows shortcuts, use long title names Changes to game shortcuts and UTF8 gamelist name fixes Mar 20, 2024
@Exzap Exzap merged commit 241915e into cemu-project:main Mar 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants