Avoid current app from showing up as "???" for others in Friend List + View friends' status #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement GetMyPlayingGame - In StartFriendSession, the gameKey will be 0 if the current foreground title id does not start with 0x00050000 (game application)
- In NexFriends::updateMyPresence, the gameKey will be 0 if the current foreground title id does not start with 0x00050000 (game application)
|
I forgot to change the other instance of gameModeMessage in nexFriend.readData causing the build to fail, sorry about that! |
Exzap
reviewed
Apr 8, 2024
src/Cafe/IOSU/legacy/iosu_fpd.cpp
Outdated
|
|
||
| auto comment_utf16 = StringHelpers::FromUtf8(frd->comment.commentString); | ||
| comment_utf16.insert(0, 1, '\0'); // avoid first character of comment from being cut off | ||
| memcpy(friendData->friendExtraData.comment, comment_utf16.c_str(), 36); |
There was a problem hiding this comment.
We have friendExtraData.comment defined as a char array, but here you are assigning it the bytes from a wide string. If this is working then we should redefine friendExtraData.comment as the proper string type. Consider using the helper class CafeWideString since that avoids having to manually memcpy
There was a problem hiding this comment.
Defined friendExtraData.comment as CafeWideString<0x12> and now using assignFromUTF8 instead of memcpy, still works. 👍
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iosu_fpd.cpp, nexFriends.cpp and nexFriends.h are edited to have these changes: