CI: Don't strip AppImage symbols #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goeiecool9999
force-pushed
the
CIAInostriptest
branch
from
eb13cd7
to
298546d
Compare
goeiecool9999
force-pushed
the
CIAInostriptest
branch
from
298546d
to
78235f4
Compare
|
This is great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out fixing the symbols in the debug output for AppImage builds was very simple.
Linux deploy strips binaries by default. They helpfully provide the
NO_STRIPenvironment variable to not strip...linuxdeploy/linuxdeploy#72
NO_STRIPnot set:NO_STRIPset to 1: