-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulkan: Refactor swapchain code. #399
Conversation
db56eef
to
d2ecfa7
Compare
Both swapchains used the same VkSurfaceFormat variable. Unlikely to cause issues, but not very safe either. |
I would move the CreateSwapchain function into SwapChainInfo but it depends on a lot of other functions in VulkanRenderer and that might make the PR too large |
b43eced
to
1d61770
Compare
fix crash because the IDE helpfully added nullptr arguments on refactor
b9181be
to
76314de
Compare
03cdb56
to
b7cef45
Compare
I tried this, but it crashes at the time I startup any game, here's the log. Crashlog for Cemu 2.0 (experimental) Stack trace0x00007ff637b74f18 +0x00354f18 Cemu_release.exe PPCRecompiler_getJumpTableBase RAX=0000000000000000 RBX=000002254687b0d0 RCX=000002254687b0d0 RDX=0000000000000001 Game infoGame: Captain Toad: Treasure Tracker Active PPC instanceNot active PPC threads0e30eaa0 Ent 00e0000c IP 00e00004 LR 00e00000 READY Aff 111 Pri 32 Name Alarm Thread |
ae7d236
to
58365a0
Compare
Changes in this PR: