Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging migration (gx2Log_printf) #761

Merged

Conversation

why-keith
Copy link
Contributor

Converts all instances of the gx2Log_printf() logging method with the newer cemuLog_log().

Part of #703

Copy link
Member

@Crementif Crementif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will wait for the CI to finish before merging.

@Crementif
Copy link
Member

Is this fully done? I might've reviewed it too soon.

@why-keith
Copy link
Contributor Author

Is this fully done? I might've reviewed it too soon.

All done. Just far fewer logs of this type than that last one

@Crementif Crementif merged commit 486e228 into cemu-project:main Apr 13, 2023
5 checks passed
@why-keith why-keith deleted the logging-migration-gx2Log_printf branch April 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants