New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging migration (socketLog_printf) #766
Logging migration (socketLog_printf) #766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other then some LR and thread context logging that could be removed.
Co-authored-by: Crementif <26669564+Crementif@users.noreply.github.com>
Attempt to fix Ubuntu build issue
This reverts commit b895da9.
Build is only failing on Ubuntu. Struggling to work out what's causing this |
I think there's some build issues on the main branch, so just ignore it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Converts all instances of the socketLog_printf() logging method with the newer cemuLog_log().
Part of #703