Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging migration (socketLog_printf) #766

Merged

Conversation

why-keith
Copy link
Contributor

Converts all instances of the socketLog_printf() logging method with the newer cemuLog_log().

Part of #703

Copy link
Member

@Crementif Crementif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other then some LR and thread context logging that could be removed.

src/Cafe/OS/libs/nsysnet/nsysnet.cpp Outdated Show resolved Hide resolved
src/Cafe/OS/libs/nsysnet/nsysnet.cpp Outdated Show resolved Hide resolved
src/Cafe/OS/libs/nsysnet/nsysnet.cpp Outdated Show resolved Hide resolved
src/Cafe/OS/libs/nsysnet/nsysnet.cpp Outdated Show resolved Hide resolved
src/Cafe/OS/libs/nsysnet/nsysnet.cpp Outdated Show resolved Hide resolved
src/Cafe/OS/libs/nsysnet/nsysnet.cpp Outdated Show resolved Hide resolved
src/Cafe/OS/libs/nsysnet/nsysnet.cpp Outdated Show resolved Hide resolved
why-keith and others added 3 commits April 14, 2023 10:47
Co-authored-by: Crementif <26669564+Crementif@users.noreply.github.com>
Attempt to fix Ubuntu build issue
@why-keith
Copy link
Contributor Author

Build is only failing on Ubuntu. Struggling to work out what's causing this

@Crementif
Copy link
Member

I think there's some build issues on the main branch, so just ignore it for now.

@why-keith why-keith marked this pull request as ready for review April 14, 2023 13:06
Copy link
Member

@Crementif Crementif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Crementif Crementif merged commit a519b01 into cemu-project:main Apr 15, 2023
4 of 5 checks passed
@why-keith why-keith deleted the logging-migration-socketLog_printf branch April 25, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants