Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a enhancements preset to BreathOfTheWild #598

Merged
merged 14 commits into from
May 15, 2023
Merged

Add a enhancements preset to BreathOfTheWild #598

merged 14 commits into from
May 15, 2023

Conversation

yemaowuxin
Copy link
Contributor

@yemaowuxin yemaowuxin commented May 13, 2023

Preset name = YeMaoWuXin's Preset (Bright colors)

Image viewing:
screenshot_1 (2)
screenshot_2 (2)
screenshot_3 (2)
screenshot_4 (2)

Copy link
Member

@Crementif Crementif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor changes would be nice to have. The screenshots do look good!

Two additional questions:

  • Is it inspired by Serfrost's Brightly preset? If yes, I think it wouldn't be necessary for you to use (Brightly) since you don't have a dimmer screen preset.
  • Which preset did you use as a base to work from and what changes did you make?

yemaowuxin and others added 8 commits May 14, 2023 00:49
Co-authored-by: Crementif <26669564+Crementif@users.noreply.github.com>
…03c9_ps.txt

Co-authored-by: Crementif <26669564+Crementif@users.noreply.github.com>
…03c9_ps.txt

Co-authored-by: Crementif <26669564+Crementif@users.noreply.github.com>
Delete description name
@yemaowuxin
Copy link
Contributor Author

yemaowuxin commented May 13, 2023

Some very minor changes would be nice to have. The screenshots do look good!

Two additional questions:

  • Is it inspired by Serfrost's Brightly preset? If yes, I think it wouldn't be necessary for you to use (Brightly) since you don't have a dimmer screen preset.
  • Which preset did you use as a base to work from and what changes did you make?

Modified on the basis of Survival of the Wild Preset (Warmer). My native language is not English, so the words are not very accurate. I want to describe it as bright and colors. That's why the word Brightly is used.Maybe Bright Colors is more accurate?

All have been modified according to your requirements.

@yemaowuxin yemaowuxin requested a review from Crementif May 13, 2023 17:12
Copy link
Member

@Crementif Crementif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think bright colors is good! Not sure what a more descriptive word would be, maybe "More Contrast" would be a good clarifier. I can merge it now if you want.

@yemaowuxin
Copy link
Contributor Author

Hmm, I think bright colors is good! Not sure what a more descriptive word would be, maybe "More Contrast" would be a good clarifier. I can merge it now if you want.

Okay, merge it. I don't modify it anymore.

@Crementif Crementif merged commit 7ce34ed into cemu-project:master May 15, 2023
@Crementif
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants