honor context deadlines, fix #53

cenkalti · Sep 21, 2018 · 047b249 · 047b249
1 parent adb73d5
commit 047b249
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/context.go b/context.go
@@ -51,9 +51,13 @@ func (b *backOffContext) Context() context.Context {
 
 func (b *backOffContext) NextBackOff() time.Duration {
 	select {
-	case <-b.Context().Done():
+	case <-b.ctx.Done():
 		return Stop
 	default:
-		return b.BackOff.NextBackOff()
 	}
+	next := b.BackOff.NextBackOff()
+	if deadline, ok := b.ctx.Deadline(); ok && time.Until(deadline) < next {
+		return Stop
+	}
+	return next
 }
diff --git a/retry.go b/retry.go
@@ -41,7 +41,7 @@ func RetryNotify(operation Operation, b BackOff, notify Notify) error {
 			return permanent.Err
 		}
 
-		if next = b.NextBackOff(); next == Stop {
+		if next = cb.NextBackOff(); next == Stop {
 			return err
 		}