Fix data race when querying GetElapsedTime() #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ExponentialBackOff.GetElapsedTime()` reads start time which is reset by `ExponentialBackOff.Reset()` which is called by `run()`, executed in a goroutine. This creates a data race just by using: ```go b := NewExponentialBackOff() ticker := backoff.NewTicker(b) b.GetElapsedTime() ``` This commit solves this by resetting the backoff timer outside the goroutine. The ticker test has been updated for this particular data race.
|
@vincentbernat Thank you! Does this PR also fix #47? |
|
This is a separate issue. I'll comment on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExponentialBackOff.GetElapsedTime()reads start time which is resetby
ExponentialBackOff.Reset()which is called byrun(), executedin a goroutine. This creates a data race just by using:
This commit solves this by resetting the backoff timer outside the
goroutine. The ticker test has been updated for this particular data
race.