Return context error from RetryNotify when done #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the context used by RetryNotify is done, we return whatever error the last operation returned. The last operation may have run a long time ago (especially when using exponential backoff), so returning last operation error may be very confusing. It makes more sense to return the context's error, which indicates exactly why the context is done.
Return context error from RetryNotify when done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the context used by RetryNotify is done, we return whatever error the last operation returned. The last operation may have run a long time ago (especially when using exponential backoff), so returning last operation error may be very confusing. It makes more sense to return the context's error, which indicates exactly why the context is done.
This fixes #82