remove GITHUB_CALLBACK_URL config because it's optional

cenkalti · Oct 2, 2014 · e9711c1 · e9711c1
1 parent 038be00
commit e9711c1
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 11 deletions.
diff --git a/docs/index.rst b/docs/index.rst
@@ -37,7 +37,6 @@ Here’s an example of how GitHub-Flask is typically initialized and configured:
     app = Flask(__name__)
     app.config['GITHUB_CLIENT_ID'] = 'XXX'
     app.config['GITHUB_CLIENT_SECRET'] = 'YYY'
-    app.config['GITHUB_CALLBACK_URL'] = 'http://example.com/github-callback'
 
     github = GitHub(app)
 
@@ -50,13 +49,6 @@ The following configuration settings exist for GitHub-Flask:
 
 `GITHUB_CLIENT_SECRET`              Your GitHub application's client secret.
 
-`GITHUB_CALLBACK_URL`               This is the URL that GitHub redirects the
-                                    user after authorization.
-                                    It must the same URL entered on your
-                                    application settings page.
-                                    You can enter something like
-                                    http://localhost:5000/github-callback
-                                    on both places during development.
 =================================== ==========================================
 
 

diff --git a/example.py b/example.py
@@ -20,7 +20,6 @@
 # Set these values
 GITHUB_CLIENT_ID = 'XXX'
 GITHUB_CLIENT_SECRET = 'YYY'
-GITHUB_CALLBACK_URL = 'http://localhost:5000/github-callback'
 
 # setup flask
 app = Flask(__name__)

diff --git a/flask_github.py b/flask_github.py
@@ -57,7 +57,6 @@ def __init__(self, app=None):
     def init_app(self, app):
         self.client_id = app.config['GITHUB_CLIENT_ID']
         self.client_secret = app.config['GITHUB_CLIENT_SECRET']
-        self.callback_url = app.config['GITHUB_CALLBACK_URL']
         self.base_url = app.config.get('GITHUB_BASE_URL', self.BASE_URL)
         self.auth_url = app.config.get('GITHUB_AUTH_URL', self.BASE_AUTH_URL)
         self.session = requests.session()

diff --git a/test_flask_github.py b/test_flask_github.py
@@ -30,7 +30,6 @@ def assert_params(*args, **kwargs):
 
         app.config['GITHUB_CLIENT_ID'] = '123'
         app.config['GITHUB_CLIENT_SECRET'] = 'SEKRET'
-        app.config['GITHUB_CALLBACK_URL'] = 'http://localhost/github-callback'
 
         github = GitHub(app)