fixed is_json_response bug (failed to account for charset in response)

[vassudanagunta]

The response from the GitHub API for 'GET user' had the Content-Type of "application/json; charset=utf-8". The is_json_response method failed to account for the charset appendage, resulting in the json never being returned by the GitHub object.

[woodb]

👍 Looks good to me, we could even just do...

return response.headers.get('Content-Type', '').startswith('application/json')

[woodb]

This also brings up an interesting issue... Is there a sandbox or test environment available to run unit tests against w/ the GitHub API?

[vassudanagunta]

I was being conservative, not wanting to match against some future mime type with the same prefix, e.g. 'application/jsonX'. I'm a python noob so perhaps a single regex would be better?

Apparently there is no GitHub API sandbox. The thing to do I guess is to create test accounts and test repos.

[cenkalti]

What about https://docs.python.org/2/library/cgi.html#cgi.parse_header ?

[woodb]

That is already handled by Werkzeug

Could just do:

return 'application/json' in request.headers.get('Content-Type', '')