Skip to content

Commit

Permalink
remove unnecessary isinstance check
Browse files Browse the repository at this point in the history
  • Loading branch information
cenkalti committed Mar 7, 2018
1 parent d2d4534 commit 199f0b7
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions kuyruk/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,26 +61,28 @@ def from_object(self, obj: Union[str, Any]) -> None:
"""Load values from an object."""
if isinstance(obj, str):
obj = importer.import_object_str(obj)

for key in dir(obj):
if key.isupper():
value = getattr(obj, key)
self._setattr(key, value)

logger.info("Config is loaded from object: %r", obj)

def from_dict(self, d: Dict[str, Any]) -> None:
"""Load values from a dict."""
for key, value in d.items():
if key.isupper():
self._setattr(key, value)

logger.info("Config is loaded from dict: %r", d)

def from_pymodule(self, name: str) -> None:
if not isinstance(name, str):
raise TypeError
module = importer.import_module(name)
for key, value in module.__dict__.items():
if (key.isupper() and not isinstance(value, types.ModuleType)):
self._setattr(key, value)

logger.info("Config is loaded from module: %s", name)

def from_pyfile(self, filename: str) -> None:
Expand All @@ -107,11 +109,13 @@ def from_env_vars(self) -> None:
value = ast.literal_eval(value)
except (ValueError, SyntaxError):
pass

self._setattr(key, value)

def _setattr(self, key: str, value: Any) -> None:
if not hasattr(self.__class__, key):
raise ValueError("Unknown config key: %s" % key)

setattr(self, key, value)


Expand Down

0 comments on commit 199f0b7

Please sign in to comment.