Replace pytest-runner with tox #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jameshilliard, After some changes in setuptools and the feature that pytest-runner relies on was deprecated, I think it is better to remove the dependency pytest-runner from the project. Could you update this PR and remove the pytest-runner completely from the project? See here, maybe it will need to change too: https://github.com/cenobites/flask-jsonrpc/blob/master/Makefile#L16= Thank you. |
jameshilliard
force-pushed
the
fix-setup-requires
branch
from
8f07768
to
7eebdb6
Compare
This isn't a build requirement so it shouldn't be under setup_requires. Migrate to tox as well since pytest-runner is deprecated. Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
jameshilliard
force-pushed
the
fix-setup-requires
branch
from
7eebdb6
to
bed0dc9
Compare
jameshilliard
changed the title
Replaced it with tox in |
nycholas
approved these changes
Jun 14, 2022
|
@jameshilliard thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a build requirement so it shouldn't be under
setup_requires.Migrate to
toxas well sincepytest-runneris deprecated.