Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stops removing outcome field #213

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stops removing outcome field #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed82d3e
Stops removing outcome field
agiix Jan 13, 2023
9d4dcd5
Added outcome field to test_hyperquack_flatten_matches_gcs_dict
agiix Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pipeline/metadata/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ def dict_to_gcs_dict_hyperquack(
measurement_dict.pop('domain_category')
measurement_dict.pop('is_known_blockpage')
measurement_dict.pop('page_signature')
measurement_dict.pop('outcome')
measurement_dict.pop('received_tls_cert_matches_domain')
return measurement_dict

Expand Down
3 changes: 2 additions & 1 deletion pipeline/metadata/test_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,8 @@ def test_hyperquack_flatten_matches_gcs_dict(self) -> None:
'controls_failed': False,
'stateful_block': False,
'measurement_id': '81e2a76dafe04131bc38fc6ec7bbddca',
'source': 'CP_Quack-https-2020-11-06-15-15-31'
'source': 'CP_Quack-https-2020-11-06-15-15-31',
'outcome': 'content/status_mismatch:302'
}
# yapf: disable
gcs_dict = schema.dict_to_gcs_dict_hyperquack(schema.flatten_to_dict(row))
Expand Down