bump up domain clustering #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging so we have everything in place to turn nightly back on |
fortuna
reviewed
Jun 6, 2023
| @@ -38,7 +38,7 @@ CREATE OR REPLACE TABLE `PROJECT_NAME.DERIVED_DATASET.merged_reduced_scans_v2` | |||
| PARTITION BY date | |||
| # Columns `source` and `country_name` are always used for filtering and must come first. | |||
| # `network` and `domain` are useful for filtering and grouping. | |||
There was a problem hiding this comment.
It may be worth mentioning that the order matters and link to https://cloud.google.com/bigquery/docs/clustered-tables#cluster_column_ordering
Also that we need domain to come after country to benefit from the default domain selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster earlier by domain. This will make FE queries generally cheaper since we have domain filtering in the default view.