update satellite outcome names #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
approved these changes
Jul 24, 2023
That would have to happen in https://github.com/censoredplanet/censoredplanet-analysis/blob/master/pipeline/metadata/hyperquack_outcome.py and would be a seperate PR from this one. On the upside that change could be merged directly into master, while this one can't be currently. |
|
Closing in favor of #257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the list here: https://docs.google.com/spreadsheets/d/131vLGGeLF-3_5ssKcGamrFhlo7eo_XQV0CiEzL24_7I/edit?resourcekey=0-6pSwdwt3v73XL5wKfvgzNg#gid=1240852033
This is currently branched off my weird side branch, but should be mergable once that is merged.
Example dashboard using these new strings: https://lookerstudio.google.com/c/u/0/reporting/2afecc26-2865-47e0-9384-76bf9356ba99/page/p_011unrxq4c
(ignore the CI error, it's a mypy update)