Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

metrics: add conversion from metricsproto.SummaryValue #66

Closed
odeke-em opened this issue Dec 10, 2018 · 1 comment
Closed

metrics: add conversion from metricsproto.SummaryValue #66

odeke-em opened this issue Dec 10, 2018 · 1 comment
Assignees

Comments

@odeke-em
Copy link
Contributor

Coming here from #65 (comment)
converting to metricsproto.SummaryValue to Stackdriver monitoring/v3 Proto is not straight forward and as per v0.8.0 of this code https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/tree/v0.8.0 doesn't even yet support this conversion.

This issue is to track that conversion for posterity and to keep it on our radar.

odeke-em added a commit to orijtech/opencensus-go-exporter-stackdriver that referenced this issue Dec 10, 2018
A reminder that we should support the conversion
from metricspb.SummaryValue to monitoring/v3 proto
whenever census-ecosystem#66 is solved.
odeke-em added a commit to orijtech/opencensus-go-exporter-stackdriver that referenced this issue Dec 10, 2018
An adapter to directly convert from OpenCensus Proto
Point to Stackdriver's monitoring/v3 Point which are
both protobuf based code backed representations.

This the first of a series of changes to allow direct
conversion of metrics so that we can use this exporter
in the OpenCensus Agent/Service exporters, but also so that
applications such as OpenCensus-PHP's daemon can begin to it too.

Also added a TODO for SummaryValue conversion:
A reminder that we should support the conversion
from metricspb.SummaryValue to monitoring/v3 proto
whenever census-ecosystem#66 is solved.

Updates census-ecosystem#64.
odeke-em added a commit to orijtech/opencensus-go-exporter-stackdriver that referenced this issue Dec 10, 2018
An adapter to directly convert from OpenCensus Proto
Point to Stackdriver's monitoring/v3 Point which are
both protobuf based code backed representations.

This the first of a series of changes to allow direct
conversion of metrics so that we can use this exporter
in the OpenCensus Agent/Service exporters, but also so that
applications such as OpenCensus-PHP's daemon can begin to it too.

Also added a TODO for SummaryValue conversion:
A reminder that we should support the conversion
from metricspb.SummaryValue to monitoring/v3 proto
whenever census-ecosystem#66 is solved.

Updates census-ecosystem#64.
@songy23
Copy link
Contributor

songy23 commented May 30, 2019

Already fixed in #152.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants