This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
transform resources for metrics exported via ExportMetricsProto api #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
May 30, 2019
| "github.com/golang/protobuf/ptypes/wrappers" | ||
| "github.com/google/go-cmp/cmp" | ||
| ) | ||
|
|
||
| func TestProtoResourceToMonitoringResource(t *testing.T) { |
There was a problem hiding this comment.
Consider adding a test where proto metrics are exported with different resources, e.g metric1 with GCE resource, then metric2 with K8S resource.
There was a problem hiding this comment.
done. It uncovered an issue. So thanks for asking to add this test.
|
@songy23 PTAL. |
songy23
approved these changes
May 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #157