Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

add test to handle multiple timeseries for Summary metrics. #220

Merged

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Sep 16, 2019

@bogdandrutu
Copy link
Contributor

Can we start using files for the input/output protos? It will be way easier to add/remove tests :) Maybe in a different PR translate all the code defined protos to files?

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #220 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage      72%   72.12%   +0.12%     
==========================================
  Files          15       15              
  Lines        1550     1550              
==========================================
+ Hits         1116     1118       +2     
+ Misses        356      355       -1     
+ Partials       78       77       -1
Impacted Files Coverage Δ
metrics_proto.go 87.68% <0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea215e...8c015d1. Read the comment docs.

@rghetia
Copy link
Contributor Author

rghetia commented Sep 16, 2019

Can we start using files for the input/output protos? It will be way easier to add/remove tests :) Maybe in a different PR translate all the code defined protos to files?

sure.

@bogdandrutu bogdandrutu merged commit 717ac5c into census-ecosystem:master Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants