Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

skip creating metric descriptor for stackdriver built-in metrics. #77

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Jan 30, 2019

fixes #76.

@rghetia
Copy link
Contributor Author

rghetia commented Jan 30, 2019

@yanweiguo I have made the change. I couldn't completely verify because I don't have access to write. I did verify that it doesn't create MetricDescriptor though. If you don't mind can you verify on your side.

Copy link
Contributor

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rghetia! LGTM with one suggestion.

stats.go Outdated Show resolved Hide resolved
stats.go Outdated Show resolved Hide resolved
Copy link
Contributor

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @rghetia!

@rghetia rghetia merged commit 0f284fd into census-ecosystem:master Jan 31, 2019
@rghetia rghetia deleted the metric_desc_example branch April 18, 2019 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats: do not create MetricDescriptor for Stackdriver built-in metrics.
5 participants