Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

UDP Client: Support writing large reports #9

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

dz0ny
Copy link
Contributor

@dz0ny dz0ny commented Oct 7, 2018

If a report is larger than 65536 bytes it will be rejected by kernel and PHP engine and never sent. With this, we ensure that the packet is always sent and that it has proper signaling (MSG_EOR or MSG_EOF).

TLDR; Solves the following issue:

PHP Warning: socket_sendto(): unable to write to socket [90]: Message too long

@dz0ny dz0ny force-pushed the patch-1 branch 2 times, most recently from 0338f50 to 0e8b14b Compare October 7, 2018 12:58
If a report is larger than 65536 it will be rejected by kernel and PHP engine and never sent. With this, we ensure that the packet is always sent and that it has proper signaling (MSG_EOR or MSG_EOF).

TLDR; Solves the following issue:

```PHP Warning:  socket_sendto(): unable to write to socket [90]: Message too long```
Copy link
Member

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, one small change.

tests/unit/Jaeger/UDPClientTest.php Show resolved Hide resolved
@chingor13
Copy link
Member

Circle CI base PHP image is having issues.

@chingor13 chingor13 merged commit 29480c3 into census-ecosystem:master Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants