-
Notifications
You must be signed in to change notification settings - Fork 74
Add cmake support for prometheus exporter #249
Add cmake support for prometheus exporter #249
Conversation
- disable building pull/push libraries - disable compression to avoid pulling dependent gzip library - disable test so it would not need to build prometheus-cpp tests
This looks great! It builds and passes tests. I tried to add the prometheus exporter to helloworld but we're missing exposer.h from Would you like to handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please run tools/format.sh
:)
Let's create another PR as this PR is self-contained. However, I identified a line too long from your commit, so I will push another commit to make the format right. |
Thanks for taking care of it. |
Agreed, let's leave |
I will address the issue you raise and follow up with you later - just saw your comments after I pushed that commit. |
Do I need to rebase from master, or merge the latest branch from master? Or are you able to squash & merge them into single commit? I believe there won't be conflict. |
We always squash in opencensus-cpp. Please:
Thanks :) |
As I don't have write access, so I cannot merge back to master.
|
Thanks! |
This resolved only part of census-instrumentation#249, because the build rule for prometheus_test_server is not added yet.
To solve #248