Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Rename TagSet to Set #47

Closed
rakyll opened this issue Oct 17, 2017 · 0 comments
Closed

Rename TagSet to Set #47

rakyll opened this issue Oct 17, 2017 · 0 comments
Assignees
@rakyll @dinooliva
Labels
tags
Milestone
R1

Comments

@rakyll
Copy link
Contributor

rakyll commented Oct 17, 2017

tags.TagSet is repeating the "tag" twice and we don't like to stuttering in Go. Rename it to Set.
@rakyll rakyll added the tags label Oct 17, 2017
@rakyll rakyll self-assigned this Oct 17, 2017
@rakyll rakyll mentioned this issue Oct 17, 2017
Merged
rakyll pushed a commit that referenced this issue Oct 19, 2017
Rename TagSet and StringValue (#51)
0abf5b3 
- Rename TagSet to Tag.
- Remove ErrKeyNotFound but rather return a bool from
(*TagSet).StringValue. There are no other errors that can
be returned other than existence/nonexistence.

Fixes #47.
Fixes #21.
@rakyll rakyll added this to the R1 milestone Dec 12, 2017
bogdandrutu pushed a commit to bogdandrutu/opencensus-go that referenced this issue Feb 15, 2019
@odeke-em
exporter: add Plugins interface as well as guide
568ccb8 
Added the TraceExporterPlugin interface of the type
```go
type TraceExporterPlugin interface {
        TraceExportersFromConfig(blob []byte, configType ConfigType) ([]TraceExporter, error)
        Stop(context.Context) error
}
```

as well as a guide and sample of an end-to-end written plugin.

This is the interface and introduction phase of fixing the
target issue. Actual plugin into `cmd/ocagent` will come
in the final change.

Updates census-instrumentation#47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakyll rakyll

@dinooliva dinooliva

Labels
tags
Projects
None yet
Milestone
R1
Development

No branches or pull requests
2 participants
@rakyll @dinooliva