Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

HTTP plugin should follow the spec #607

Closed
rakyll opened this issue Mar 20, 2018 · 1 comment
Closed

HTTP plugin should follow the spec #607

rakyll opened this issue Mar 20, 2018 · 1 comment
Assignees
@rakyll

Comments

@rakyll
Copy link
Contributor

rakyll commented Mar 20, 2018

ochttp package should implement the behavior explained in https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/HTTP.md.
@rakyll rakyll self-assigned this Mar 20, 2018
@rakyll
Copy link
Contributor Author

rakyll commented Mar 20, 2018

Initially, we need to implement the #525 so the exporters can set the kind without user having to depend on "Sent" and "Recv" prefixes.

rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Span names shouldn't be prefixed with Sent and Recv
c05c542 
Instead set them for some exporters that cannot
differentiate client spans from server spans in their model.

Also recored the request port.

Fixes census-instrumentation#607.
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Span names shouldn't be prefixed with Sent and Recv
d080bdf 
Instead set them for some exporters that cannot
differentiate client spans from server spans in their model.

Also recored the request port.

Fixes census-instrumentation#607.
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Span names shouldn't be prefixed with Sent and Recv
33e222c 
Instead set them for some exporters that cannot
differentiate client spans from server spans in their model.

Also recored the request port.

Fixes census-instrumentation#607.
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Span names shouldn't be prefixed with Sent and Recv
0788480 
Instead set them for some exporters that cannot
differentiate client spans from server spans in their model.

Fixes census-instrumentation#607.
@rakyll rakyll mentioned this issue Mar 20, 2018
Merged
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Span names shouldn't be prefixed with Sent and Recv
5f5db37 
Instead set them for some exporters that cannot
differentiate client spans from server spans in their model.

Fixes census-instrumentation#607.
rakyll added a commit to rakyll/opencensus-go that referenced this issue Mar 20, 2018
@rakyll
Span names shouldn't be prefixed with Sent and Recv
3f8ae01 
Instead set them for some exporters that cannot
differentiate client spans from server spans in their model.

Fixes census-instrumentation#607.
rakyll added a commit that referenced this issue Mar 21, 2018
@rakyll
Span names shouldn't be prefixed with Sent and Recv (#616)
b8f3b91 
Instead set them for some exporters that cannot
differentiate client spans from server spans in their model.

Fixes #607.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rakyll rakyll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rakyll