Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Remove force collection #97

Closed
rakyll opened this issue Nov 10, 2017 · 0 comments · Fixed by #100
Closed

Remove force collection #97

rakyll opened this issue Nov 10, 2017 · 0 comments · Fixed by #100
Assignees
Milestone

Comments

@rakyll
Copy link
Contributor

rakyll commented Nov 10, 2017

Force collection became identical to the subscription after subscription via channels is removed. Remove force collection related APIs.

@rakyll rakyll added the stats label Nov 10, 2017
@rakyll rakyll self-assigned this Nov 10, 2017
rakyll added a commit to rakyll/opencensus-go that referenced this issue Nov 10, 2017
With the new subscription model, force collection and subscription
became the same behaviors with different API names. Remove force collection.

Also fixes the race at isCollecting by removing it.

Fixes census-instrumentation#97.
rakyll added a commit to rakyll/opencensus-go that referenced this issue Nov 13, 2017
With the new subscription model, force collection and subscription
became the same behaviors with different API names. Remove force collection.

Also fixes the race at isCollecting by removing it.

Fixes census-instrumentation#97.
rakyll pushed a commit that referenced this issue Nov 13, 2017
With the new subscription model, force collection and subscription
became the same behaviors with different API names. Remove force collection.

Also fixes the race at isCollecting by removing it.

Fixes #97.
@rakyll rakyll added this to the R1 milestone Dec 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants