Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

change unit to dimensionless when aggregation is count. #1157

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Aug 29, 2019

The unit for Aggregation Count should always be Dimensionless.
For example if latency measures (with unit "ms") is used into two views

  • View1 : Aggregation Sum
  • View2: Aggregation Count
    then the unit "ms" for View2 doesn't make sense. It should be Dimensionless.

@rghetia rghetia requested review from rakyll and a team as code owners August 29, 2019 06:37
@rghetia rghetia requested a review from songy23 August 29, 2019 06:37
Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rghetia rghetia merged commit 29aa3ca into census-instrumentation:master Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants