This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Add tests for gRPC span duration and Stackdriver gRPC exporting #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semistrict
force-pushed
the
span-duration
branch
from
a484c1d
to
616f26e
Compare
semistrict
commented
Mar 16, 2018
| @@ -110,184 +44,3 @@ func TestClientHandler_traceTagRPC(t *testing.T) { | |||
| t.Fatal("no metadata") | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
moved all this to trace_test.go
semistrict
changed the title
semistrict
force-pushed
the
span-duration
branch
from
616f26e
to
e36b4a5
Compare
rakyll
approved these changes
Mar 19, 2018
| @@ -81,3 +82,28 @@ func TestExport(t *testing.T) { | |||
| exporter.Flush() | |||
| exporter.Flush() | |||
| } | |||
|
|
|||
| func TestGrpc(t *testing.T) { | |||
internal/testpb/impl.go
Outdated
| } | ||
| } | ||
|
|
||
| func NewTestClient(l interface{ Fatal(args ...interface{}) }) (client FooClient, cleanup func()) { |
There was a problem hiding this comment.
Please pass t *testing.T instead of l. And you can mark this function as a helper.
semistrict
force-pushed
the
span-duration
branch
from
e36b4a5
to
603ffc2
Compare
semistrict
force-pushed
the
span-duration
branch
from
603ffc2
to
aa454af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.