-
Notifications
You must be signed in to change notification settings - Fork 328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rakyll, LGTM!
trace/trace.go
Outdated
@@ -100,6 +100,13 @@ func WithSpan(parent context.Context, s *Span) context.Context { | |||
return context.WithValue(parent, contextKey{}, s) | |||
} | |||
|
|||
// All available span kinds. | |||
const ( | |||
SpanKindUnspecified = iota |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, I was just about to comment on this, on the previous change to ask for this change :)
@bogdandrutu @Ramonza want to take a look before I merge? This is an API addition. |
|
||
// TODO(jbd): Remove start options. | ||
// SpanKind represents the kind of a span. If none is set, | ||
// SpanKindUnspecified is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would specify that these must be one of the SpanKindUnspecified, SpanKindServer, SpanKindClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Updates #525.