This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Introduce SpanKind support #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
approved these changes
Mar 20, 2018
trace/trace.go
Outdated
| @@ -100,6 +100,13 @@ func WithSpan(parent context.Context, s *Span) context.Context { | |||
| return context.WithValue(parent, contextKey{}, s) | |||
| } | |||
|
|
|||
| // All available span kinds. | |||
| const ( | |||
| SpanKindUnspecified = iota | |||
There was a problem hiding this comment.
Perfect, I was just about to comment on this, on the previous change to ask for this change :)
|
@bogdandrutu @Ramonza want to take a look before I merge? This is an API addition. |
bogdandrutu
approved these changes
Mar 20, 2018
|
|
||
| // TODO(jbd): Remove start options. | ||
| // SpanKind represents the kind of a span. If none is set, | ||
| // SpanKindUnspecified is used. |
There was a problem hiding this comment.
I would specify that these must be one of the SpanKindUnspecified, SpanKindServer, SpanKindClient
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #525.