This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Avoid global configuration overriding all #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @savaki |
bogdandrutu
approved these changes
Mar 28, 2018
trace/config.go
Outdated
| // ApplyConfig applies changes to the global tracing configuration. | ||
| // | ||
| // Fields not provided in the given config is going to be preserved. | ||
| func ApplyConfig(cfg Config) { | ||
| if cfg.DefaultSampler == nil { | ||
| cfg.DefaultSampler = newDefaultSampler() |
There was a problem hiding this comment.
Here you don't want to reinstall the default, you want to keep the previous value. Maybe worth having a test.
|
Nice! |
semistrict
approved these changes
Mar 28, 2018
odeke-em
reviewed
Mar 28, 2018
trace/config.go
Outdated
| func SetConfig(cfg Config) { | ||
| // ApplyConfig applies changes to the global tracing configuration. | ||
| // | ||
| // Fields not provided in the given config is going to be preserved. |
There was a problem hiding this comment.
Minor typo:
s/is going to/are going to/
odeke-em
reviewed
Mar 29, 2018
| func TestApplyZeroConfig(t *testing.T) { | ||
| cfg := config | ||
| ApplyConfig(Config{}) | ||
| if got, want := reflect.ValueOf(config.DefaultSampler).Pointer(), reflect.ValueOf(cfg.DefaultSampler).Pointer(); got != want { |
There was a problem hiding this comment.
Sorry, what is this testing for?
There was a problem hiding this comment.
Whether config.DefaultSampler and cfg.DefaultSampler pointing to the same pointer.
It will be more common for the users to tweak a few settings rather than all. Rename SetConfig to ApplyConfig and only override the non-zero values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be more common for the users to tweak a few
settings rather than all.
Rename SetConfig to ApplyConfig and only
override the non-zero values.