This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Create a Go execution tracer task for each span #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semistrict
approved these changes
Apr 18, 2018
trace/trace.go
Outdated
| @@ -259,6 +266,7 @@ func (s *Span) End() { | |||
| return | |||
| } | |||
| s.exportOnce.Do(func() { | |||
There was a problem hiding this comment.
should we rename this Once now that it covers strictly more than just exporting?
There was a problem hiding this comment.
Renamed it to endOnce.
This allows us to associate OpenCensus spans with execution tracer tasks and allow users to have fine-grained details about the runtime events happened in the lifetime of a distributed tracing span.
|
I will write a blog post to give an example. The runtime/trace APIs are still not finalized, so we shouldn't create too much documentation at this point. |
bcmills
reviewed
May 11, 2018
| ) | ||
|
|
||
| func startExecutionTracerSpan(ctx context.Context, name string) (context.Context, func()) { | ||
| return t.NewContext(ctx, name) |
There was a problem hiding this comment.
This no longer builds as of https://golang.org/cl/112198.
(CC: @hyangah @pjweinbgo)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to associate OpenCensus spans with execution
tracer tasks and allow users to have fine-grained details
about the runtime events happened in the lifetime of a
distributed tracing span.