This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Move version accessor to the opencensus package #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version returns the OpenCensus library version. It is not an exporter utility. If it is an exporter utility, it shouldnt be in exportutil. In Go, utility packages are organized under an existing package. For example, io/iotuil or net/http/httputil. Fixes census-instrumentation#779.
semistrict
reviewed
Jun 6, 2018
exporterutil/version.go
Outdated
|
|
||
| // Version is the current release version of OpenCensus in use. It is made | ||
| // available for exporters to include in User-Agent-like metadata. | ||
| var Version = "0.13.0" |
There was a problem hiding this comment.
This is already in a released version unfortunately, we need to deprecate and remove according to the policy.
|
Even though it is only used by the Stackdriver exporter, both are at released versions so it requires a coordinated removal. I recommend we just follow the deprecation policy and remove in a month. |
|
I reverted the breaking change and deprecated the package. PTAL. |
semistrict
approved these changes
Jun 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version returns the OpenCensus library version. It is not an exporter utility.
If it is an exporter utility, it shouldnt be in exportutil. In Go, utility packages
are organized under an existing package.
For example, io/iotuil or net/http/httputil.
This API should not yet be picked by anyone else other than the exporters.
Fixes #779.