This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Fix race in RetrieveData #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RetrieveData previously would return pointers to internal aggregators that might subsequently be mutated based on future view updates. Instead, have collectedRows always return an immutable snapshot of the collected aggregators (by calling clone on each one). Since we do this, we can also avoid a defensive copy on the normal export path. Fixes: census-instrumentation#795
rakyll
approved these changes
Jun 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RetrieveData previously would return pointers to internal
aggregators that might subsequently be mutated based on future
view updates.
Instead, have collectedRows always return an immutable snapshot
of the collected aggregators (by calling clone on each one).
Since we do this, we can also avoid a defensive copy on the normal
export path.